Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check defined in src for cache in companion #14557

Merged
merged 1 commit into from Feb 28, 2022

Conversation

bishabosha
Copy link
Member

Added a method isDefinedInSource to check that symbol was defined in some sort of source file - e.g. a previous line on the repl.

fixes #14540

@bishabosha bishabosha requested review from odersky and removed request for nicolasstucki February 28, 2022 08:32
@bishabosha bishabosha assigned odersky and unassigned nicolasstucki Feb 28, 2022
@nicolasstucki nicolasstucki added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Feb 28, 2022
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a nit pick

@bishabosha bishabosha assigned dwijnand and unassigned odersky Feb 28, 2022
@dwijnand dwijnand merged commit 29fc554 into scala:main Feb 28, 2022
@dwijnand dwijnand deleted the fix-#14540 branch February 28, 2022 17:56
@bishabosha bishabosha added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Mar 2, 2022
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mirror.Sum for enums are not cached in companion in REPL
5 participants