Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @juggle/resize-observer? #241

Open
jaulz opened this issue Sep 27, 2022 · 4 comments
Open

Remove @juggle/resize-observer? #241

jaulz opened this issue Sep 27, 2022 · 4 comments

Comments

@jaulz
Copy link
Contributor

jaulz commented Sep 27, 2022

I wonder if @juggle/resize-observer is necessary at all as most browsers anyway support it and in case someone wants to support older versions he could still load the polyfill optionally? Just noticed while checking the code because of minor performance issues...
@07akioni
Copy link
Owner

Maybe after 1 or 2 years we can remove it? I notice that it seems some users user chrome of version 5x.

@07akioni
Copy link
Owner

07akioni commented Sep 29, 2022 •
edited

I remember in 2018, safari didn't support ResizeObserver.

@07akioni
Copy link
Owner

What are the performance issues?

@jaulz
Copy link
Contributor Author

jaulz commented Sep 29, 2022

I was facing some issues when using checked-row-keys prop of DataTable and saw in the profiler that the ResizeObserver took most of the time. Without the polyfill it felt faster though I did not ran any quantitive measurements.

@jaulz jaulz mentioned this issue Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaulz @07akioni