Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize/ise FluentHub #244

Merged
merged 12 commits into from
Sep 4, 2022
Merged

Localize/ise FluentHub #244

merged 12 commits into from
Sep 4, 2022

Conversation

Lamparter
Copy link
Collaborator

⏱️ Before you start

Relying on AZP to build the app.

↗️ Related/Fixed issues

📄 Description

Add all strings to resource files.

@Lamparter Lamparter self-assigned this Aug 29, 2022
@Lamparter Lamparter added this to the FluentHub v0.5 milestone Aug 29, 2022
@Lamparter
Copy link
Collaborator Author

lool now i need to relocalise mainpage

@Lamparter
Copy link
Collaborator Author

@onein528 Localising settings pages that aren't Account/Appearance pages will be difficult as they don't work for me. Do they work for you? Or is that just a problem on my machine?

@0x5bfa
Copy link
Owner

0x5bfa commented Sep 1, 2022

Shouldn't touch settings pages. It's under construction. Very unstable and undeveloped.

@0x5bfa
Copy link
Owner

0x5bfa commented Sep 1, 2022

I will develop them. Sorry inconvenient

@Lamparter
Copy link
Collaborator Author

I will develop them. Sorry inconvenient

No problem!

@Lamparter Lamparter linked an issue Sep 1, 2022 that may be closed by this pull request
Empty space above notification on home page #249
Closed
2 tasks
@Lamparter Lamparter mentioned this pull request Sep 1, 2022
Closed
2 tasks
@0x5bfa 0x5bfa changed the title Localise FluentHub Localize FluentHub Sep 1, 2022
@0x5bfa
Copy link
Owner

0x5bfa commented Sep 1, 2022

I hate ‘s’.....

@Lamparter
Copy link
Collaborator Author

I hate ‘s’.....

I hate 'z'.....

@hunterlan
Copy link
Contributor

I hate ‘s’.....

I hate 'z'.....

i18n? :D

@0x5bfa 0x5bfa self-requested a review September 2, 2022 14:24
0x5bfa
0x5bfa previously approved these changes Sep 2, 2022
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're really nice! LGTM, so far.

@0x5bfa
Copy link
Owner

0x5bfa commented Sep 2, 2022

Btw, can you fix automated Azure Pipeline builds errors?

@github-actions github-actions bot added the pr-triage/ready-to-merge This PR has been approved by an FH member. label Sep 2, 2022
@0x5bfa 0x5bfa removed the pr-triage/ready-to-merge This PR has been approved by an FH member. label Sep 2, 2022
@0x5bfa
Copy link
Owner

0x5bfa commented Sep 4, 2022

Can I merge this? @DeveloperWOW64

0x5bfa
0x5bfa approved these changes Sep 4, 2022
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work!

@github-actions github-actions bot added the pr-triage/ready-to-merge This PR has been approved by an FH member. label Sep 4, 2022
@Lamparter
Copy link
Collaborator Author

Can I merge this? @DeveloperWOW64

Hmm. @onein528 Not really, as I haven't done everything I planned to, but I have school now so I if I continued it would be slow, eventual work. But it's still possible.
Here's my checklist:

  • AppSettings (sort of)
  • Home
  • Organizations
  • Repositories
  • SignIn (as completed by you ofc)
  • Users
  • MainPage

@0x5bfa
Copy link
Owner

0x5bfa commented Sep 4, 2022

I have breaking changes in ‘Improve error handling’. It's a really breaking change. Conflicts....

@Lamparter
Copy link
Collaborator Author

Lamparter commented Sep 4, 2022 •
edited

I have breaking changes in ‘Improve error handling’. It's a really breaking change. Conflicts....

Okay. Then you can merge. After you merge #251 I will move to WASDK and then we can finish localisation. What do you think @onein528?

@0x5bfa
Copy link
Owner

0x5bfa commented Sep 4, 2022

Really nice.

@0x5bfa 0x5bfa marked this pull request as ready for review September 4, 2022 07:08
@0x5bfa 0x5bfa merged commit 4483190 into main Sep 4, 2022
@0x5bfa 0x5bfa deleted the localise branch September 4, 2022 07:08
@Lamparter Lamparter changed the title Localize FluentHub Localize/ise FluentHub Sep 26, 2022
@Lamparter Lamparter linked an issue Oct 4, 2022 that may be closed by this pull request
Feature: Localize the app #317
Open
@Lamparter Lamparter mentioned this pull request Oct 4, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

Assignees

@Lamparter Lamparter

Labels
pr-triage/ready-to-merge This PR has been approved by an FH member.
Projects
None yet
Milestone
FluentHub v1.0.0
Development

Successfully merging this pull request may close these issues.

Feature: Localize the app Empty space above notification on home page
3 participants
@Lamparter @0x5bfa @hunterlan