Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vexflow needs a slur/phrase/tie curve type #1423

Open
AaronDavidNewman opened this issue Jul 10, 2022 · 0 comments
Open

Vexflow needs a slur/phrase/tie curve type #1423

AaronDavidNewman opened this issue Jul 10, 2022 · 0 comments

Comments

@AaronDavidNewman
Copy link
Collaborator

Does it?

Slurs are currently implemented with curve.ts. While the implementation of curve is fine, the interface is limited and I don't know if that can be fixed in a backwards-compatible way. Instead, I propose having static functions that fill in slur parameters to make them equivalent to the existing curve or tie implementation.

The slur class would overcome the following limitations:

  • allow an arbitrary number of control points
  • allow explicit orientation up/down or auto
  • allow placement on the note head side with a specific pitch index
  • allow x-offset on begin and end sides of the slur
  • line properties like dashed (maybe this can be done now with context?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants