Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Links Behind the Header and Extra Unknown Test #1575

Open
ronyeh opened this issue Jun 5, 2023 · 0 comments
Open

Footer Links Behind the Header and Extra Unknown Test #1575

ronyeh opened this issue Jun 5, 2023 · 0 comments
Assignees

Comments

@ronyeh
Copy link
Collaborator

ronyeh commented Jun 5, 2023

There is still a small bug where the footer links are hidden behind the header, and one of the tests seems to be rendered off to the left. Can you investigate? We can perhaps merge the footer links into the header... since it is less likely someone will scroll all the way to the bottom of the huge page of tests.

Bug1

Additionally, I had added a short sentence saying "Please wait a moment while the tests run....", which your PR removed. I think it would be useful to have that in case the tests take a long time to run. On my machine, the webpage looks broken until the tests all finish:

    <h3>
        Please wait a moment while the tests run....<br /><br />
        See the: <a id="vex-src" target="_blank"></a>. Don't forget to run the
        <a href="https://github.com/0xfe/vexflow/wiki/Visual-Regression-Tests">Visual Regression Tests</a>!
    </h3>

Originally posted by @ronyeh in #1574 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants