Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocorrect and autocapitalization not working on iOS Safari #30

Closed
josephdpurcell opened this issue Dec 27, 2022 · 5 comments
Closed

Comments

@josephdpurcell
Copy link

josephdpurcell commented Dec 27, 2022

Description

The autocorrect and autocapitalization features do not work on iOS for the Markdown input.

Steps to reproduce

  1. Install Agit CMS
  2. Login
  3. Create a file
  4. In the content area no characters get autocapitalized (eg after a period)
  5. Notice that entering two spaces does not result in a period followed by a space
  6. Notice that misspelled words do not result in a prompt for the correct spelling

Versions

agitcms version: 2.0.5
node version: 16.18.0
iOS Safari version: 15

Recording

I am attaching a recording of the behavior.

FullSizeRender.MOV
@josephdpurcell
Copy link
Author

Some context: I am in search of a "good" markdown editing experience, which in my opinion includes these features. I am taking notes on directus/directus#16762, which includes a link to a spreadsheet that has an evaluation of various editors and CMS's.

The lack of support for autocorrect and autocapitalization is a common issue I'm finding. Here are some related tickets:

@josephdpurcell josephdpurcell changed the title Autocorrect and autocapitalization not working on iOS Autocorrect and autocapitalization not working on iOS Safari Dec 27, 2022
@0xsuk
Copy link
Owner

0xsuk commented Dec 27, 2022

Issue confirmed.
This is probably an issue with Codemirror, a dependency that powers the markdown editor.
The reason I can tell so is that all of the repo you listed above use Codemirror internally.
(e.g. https://github.com/directus/directus/search?q=codemirror)

I found a similar issue in Codemirror.
You might want to consider contributing to Codemirror or search for CMS that does not use Codemirror.

@0xsuk 0xsuk closed this as completed Dec 27, 2022
@josephdpurcell
Copy link
Author

Thanks for the prompt reply @0xsuk!

I confirmed that CodeMirror5 has the issue, see codemirror/codemirror5#7009.

But CodeMirror6 does not, see codemirror/dev#1020.

My adventure started with a simple diagnosis of the issue on Directus but has evolved into evaluating every editor and CMS I can, but time is limiting. Here is my current results: https://docs.google.com/spreadsheets/d/18v2G44v0ix41xbAseOIcMcFOMNluc67IJz9f2U5IpRo/edit?usp=sharing

@0xsuk 0xsuk reopened this Dec 27, 2022
@0xsuk
Copy link
Owner

0xsuk commented Dec 27, 2022

30beb0f have fixed the issue.

I don't know why but there's no squiggly red warning showing up under the incorrect word. I think that's not much of a problem so I'm closing this issue.

@0xsuk 0xsuk closed this as completed Dec 27, 2022
@josephdpurcell
Copy link
Author

Yes! Amazing! I just confirmed it works using the same criteria for which I reported.

Thank you for making this change so quickly!

Of 16 CMS's I evaluated, at present only Agit CMS and Typemill support the autocorrect/punctuate/capitalize features on iOS.

One additional change to consider would be to enable autocorrect. Based on my testing with CodeMirror6 this would not adversely effect the authoring experience of Markdown. (I may attempt to contribute said change if I can, but at minimum not likely for another week.)

PS. This is a really amazing project. There are several reasons why I like it more than others I've evaluated; I'll hopefully share more thoughts than just the spreadsheet at a future date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants