Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough Copy should always be incremental #1109

Closed
zachleat opened this issue Apr 21, 2020 · 5 comments
Closed

Passthrough Copy should always be incremental #1109

zachleat opened this issue Apr 21, 2020 · 5 comments

Comments

@zachleat
Copy link
Member

zachleat commented Apr 21, 2020

While incremental for passthrough copy is shipping via #977 in 0.11.0, I think a very strong case can be made to always use incremental behavior for passthrough copy files, specifically:

  1. When a passthrough copy file changes during watch, just copy the one file (no other templates are processed)
  2. When a template changes that is not a passthrough copy file during watch, the passthrough copy file is not copied.
@zachleat zachleat added the needs-discussion Please leave your opinion! This request is open for feedback from devs. label Apr 21, 2020
@zachleat zachleat added this to Queue in Incremental Builds via automation Apr 21, 2020
@zachleat zachleat changed the title Passthrough Copy should be always-on incremental Passthrough Copy should always be incremental Apr 21, 2020
@marcfilleul
Copy link

+1

@tarasis
Copy link

tarasis commented Feb 5, 2022

Does incremental with passthrough copy only work with WATCH or SERVE? Atm it seems the --incremental doesn't work on its own. Which means each new update (for now) copies 190 files needlessly. Sure its done in ½ a second but its wear and tear that isn't needed.

My ideal it push changes to server, it checks out the new head, builds incrementally (aka only builds what's changed) and then that's served.

[11ty] Copied 190 files / Wrote 2 files in 0.41 seconds (v1.0.0)

@zachleat zachleat added this to the Eleventy 2.0.0 milestone Jun 23, 2022
@zachleat
Copy link
Member Author

A better resolution to this issue will be shipping with 2.0.0-canary.12: #2456

Works in both --incremental and standard modes.

@zachleat zachleat removed the needs-discussion Please leave your opinion! This request is open for feedback from devs. label Jun 23, 2022
@zachleat zachleat moved this from Queue to Closed in Incremental Builds Dec 21, 2022
@zachleat
Copy link
Member Author

@tarasis sorry to circle back here late but that feature requires Cold Start incremental, which is on the roadmap! Subscribe to #984

@zachleat
Copy link
Member Author

Note that this feature was swapped to opt-in in 2.0.0-canary.31: https://fosstodon.org/@eleventy/109705218587201477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants