Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion]: Reduce .method--title line-height #420

Open
melchoyce opened this issue Dec 22, 2023 · 1 comment
Open

[Suggestion]: Reduce .method--title line-height #420

melchoyce opened this issue Dec 22, 2023 · 1 comment
Labels
fix post-release issue to be fixed after release of a new guide front end Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods" methods design review Issues that come out of the pre-migration design review for methods small

Comments

@melchoyce
Copy link
Member

Description and Screenshots

Could we update the line-height on the method title class to Token 3 (1.35)?

Before:
image
So big :(

After:
image

Link to where you found the issue

https://federalist-8bc0b42c-5fd0-4ae8-9366-cd9c265a4446.sites.pages.cloud.gov/preview/18f/guides/eoc/design-review-template/methods/discover/stakeholder-and-user-interviews/

Reproduction steps (if necessary)

No response
@melchoyce melchoyce added Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods" Guides methods design review Issues that come out of the pre-migration design review for methods labels Dec 22, 2023
@echappen echappen added fix pre-release issue to be fixed before releasing a new guide fix post-release issue to be fixed after release of a new guide and removed fix pre-release issue to be fixed before releasing a new guide labels Dec 27, 2023
@echappen
Copy link
Contributor

Marking this as fix post-release, since line height is same from old site to new (51.9px, both inherited from .usa-prose)

@melchoyce melchoyce mentioned this issue May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix post-release issue to be fixed after release of a new guide front end Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods" methods design review Issues that come out of the pre-migration design review for methods small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@melchoyce @echappen @bpdesigns