Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: besides PRs opened in December, also count PRs merged in December #1789

Open
Habbie opened this issue Jan 30, 2017 · 2 comments
Open

Comments

@Habbie
Copy link

Habbie commented Jan 30, 2017

PRs can be ongoing work. I wanted 24pullrequests to motivate me to finish already-opened PRs that had received feedback that required additional work, but then I realised this would not help my 'score'. Please consider this :)

@adamyeats
Copy link
Contributor

Hey @Habbie, we actually did some work with regards to merged PRs in 2016. There is some discussion about this here, here and here. Are you thinking of some functionality that is outside what we've talked about in these?

FWIW, I believe we are planning an update to how the concept of gifts work this year so merged PRs play a bigger role.

@Habbie
Copy link
Author

Habbie commented Jan 31, 2017

If I'm reading correctly, those discussion are about people pushing the merge button. I mean the situation where I file a PR in November, feedback comes back, some time in December I push a few more commits, and the maintainer merges my work.

Looking forward to the improvements this year in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants