Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Create other date out of range #3492

Open
mbiesiad opened this issue Dec 3, 2021 · 1 comment
Open

[BUG]: Create other date out of range #3492

mbiesiad opened this issue Dec 3, 2021 · 1 comment
Assignees
@andrew
Labels
bug help wanted

Comments

@mbiesiad
Copy link
Contributor

mbiesiad commented Dec 3, 2021

Describe the bug

At this moment user can create a contribution with date other than 1-24 Dec (described in the description).

(it is greyed out when selecting from the calendar).

To Reproduce

Go to:
https://24pullrequests.com/dashboard

Fill the fields, and set by manual date "out of range", ie. 28th Dec.
See that contribution has been taken into account.

Expected Behavior

Description says about range: 1-24 Dec. It could be protected from entering other values out of range.

Display the appropriate notification.

Screenshot/ Video

Screenshots attached:

image

image

Additional context

No response
@mbiesiad mbiesiad added the bug label Dec 3, 2021
@andrew
Copy link
Member

andrew commented Dec 5, 2021

Screenshot 2021-12-05 at 06 31 01

On a related note, we should hide currently invalid dates from the homepage

@andrew andrew self-assigned this Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew andrew

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrew @mbiesiad