Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revive coverall and apply it on integration tests #2683

Closed
carmenfan opened this issue Jul 10, 2021 · 1 comment
Closed

revive coverall and apply it on integration tests #2683

carmenfan opened this issue Jul 10, 2021 · 1 comment
Labels
Maintenance

Comments

@carmenfan
Copy link
Member

Description

coverall was running on unit tests, but with mongoose we couldn't run it with integrated tests. This was also temporary disabled as of #2678 as there's some problem with lcov erroring out (sounds like a problem with istanbul (getting the same error as this istanbuljs/istanbuljs#499)

Goals

  • re-enable coveralls
  • make coverall run for integrated tests too

Tasks

Related Resources
@carmenfan carmenfan mentioned this issue Jul 11, 2021
Merged
@carmenfan
Copy link
Member Author

carmenfan commented Oct 26, 2021 •
edited

closing - This is N/A as we're doing code coverage check with jest on V5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carmenfan