Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fast-glob with fdir in vite #38

Open
43081j opened this issue Apr 13, 2024 · 0 comments
Open

Replace fast-glob with fdir in vite #38

43081j opened this issue Apr 13, 2024 · 0 comments

Comments

@43081j
Copy link
Owner

43081j commented Apr 13, 2024

Vite uses fast-glob in a few places. For example:

https://github.com/vitejs/vite/blob/6c323d5b3ab3cdf81d21bbe965ed3c36aa7f0589/packages/vite/src/node/server/warmup.ts#L77-L80

Note that it also uses fast-glob to escape glob-like paths, so they may be fine to keep around.

Everywhere else, we could use fdir which is a zero-dependency alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant