Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend invalid escape sequences rule to other tagged template literals #179

Open
mikejamesthompson opened this issue Oct 3, 2023 · 1 comment

Comments

@mikejamesthompson
Copy link

Template literals used as values for the css and svg tag functions are vulnerable to the same issues with invalid escape sequences as the html tag function.

For example the following code leads to an empty CSS result with no error or warning to indicate what's gone wrong:

const styles = css`
  p::before {
    content: "\2716";
  }
`;

I'd be in favour of expanding the no-invalid-escape-sequences rule to cover these other kinds of template literals.

Happy to do a PR for this with docs changes if that's helpful.

@43081j
Copy link
Owner

43081j commented Oct 3, 2023

i think you're right

so far we've stayed away from the css templates since something like stylelint should be responsible for that. but this particular case is actually about the JS around the template, so we're probably ok.

we should probably create some util function like isLitTemplate which basically asserts that its a html, css or svg tagged template expr.

we don't need to update the other rules to use that yet, so we can keep this tightly scoped. then just need to update the docs to mention that we check all 3 for this rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants