Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: depend on eslint-plugin-wc #143

Closed
wants to merge 3 commits into from
Closed

feat: depend on eslint-plugin-wc #143

wants to merge 3 commits into from

Conversation

43081j
Copy link
Owner

@43081j 43081j commented Nov 26, 2022

Not everyone is aware it exists and really they should be used together, so we may as well just depend on it.

Fixes #85

@43081j
Copy link
Owner Author

43081j commented Nov 26, 2022

this is looking less and less possible the more i look at it.

apparently eslint resolves plugins from the cwd which means we'd have to require the consumer to install both as peers anyway to be safe. if we tried to rely on the dependency here, it could be nested and will fail to resolve at lint time.

kinda sucks, guess i might throw this away after all

thoughts @stramel?

@stramel
Copy link
Contributor

stramel commented Nov 26, 2022

I think using the shared config that extends the recommended WC plugin config is the right route. Just need to inform the consumers they need to also install WC plugin as well. Eslint documents that under their shared config section.

@43081j
Copy link
Owner Author

43081j commented Dec 19, 2022

im gonna abandon this until eslint flat configs are more of a thing (less experimental), then we can have a much simpler hierarchy (since it allows chaining plugins like this).

@43081j 43081j closed this Dec 19, 2022
@43081j 43081j deleted the wc branch December 19, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish a recommended config which uses wc plugin
2 participants