Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly update no-constructor-params rule to allow optional params #53

Open
43081j opened this issue May 10, 2021 · 0 comments
Open

Possibly update no-constructor-params rule to allow optional params #53

43081j opened this issue May 10, 2021 · 0 comments

Comments

@43081j
Copy link
Owner

43081j commented May 10, 2021

You could in theory have constructor parameters as long as they are optional:

class Foo extends HTMLElement {
  constructor(a?: string, b?: string) {
    // fine
  }
}

We could update the rule to check for this and allow it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant