Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correct string encoding #1

Open
43081j opened this issue Oct 23, 2013 · 2 comments
Open

Implement correct string encoding #1

43081j opened this issue Oct 23, 2013 · 2 comments
Labels

Comments

@43081j
Copy link
Owner

43081j commented Oct 23, 2013

Currently strings are read as-is, byte by byte using a Uint8Array. The downside of this is that characters in high UTF-16/UTF-8 ranges will likely break or be malformed.

I'm not too sure about this but I'll assume it is an issue anyhow.

See here.

@seeya
Copy link

seeya commented Jan 31, 2014

Trying to read UTF-8 characters (chinese), it just returns null. Any solution?

@43081j
Copy link
Owner Author

43081j commented Feb 2, 2014

Could you possibly upload an example MP3 somewhere?

or to avoid the obvious copyright implications, find the block in a hex editor and paste it here (i guess its TIT2, the title, or TPE1, the artist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants