Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index out of range [when parsing images] #10

Open
wyqydsyq opened this issue Feb 25, 2014 · 0 comments
Open

Index out of range [when parsing images] #10

wyqydsyq opened this issue Feb 25, 2014 · 0 comments

Comments

@wyqydsyq
Copy link

The parser freaks out on some embedded images, it seems completely random as to what images do and don't trip it:

Uncaught node.js Error 

Error: Index out of range.
    at Object.ID3Frame.parse (/home/damon/projects/tunes/node_modules/id3js/dist/id3.js:696:13)
    at eval (/home/damon/projects/tunes/node_modules/id3js/dist/id3.js:943:24)
    at eval (/home/damon/projects/tunes/node_modules/id3js/dist/id3.js:118:4)
    at Object.wrapper [as oncomplete] (fs.js:454:17)

An example of one it's breaking on: http://pastebin.com/1RRDqknW

As you can see it kinda just cuts off part way through parsing the image.

If I delete the image from the ID3 tag, it parses that file fine and then breaks on a later one.

The only thing the breaking images seem to have had in common is that they're mostly fairly high res (both this and the previous one were 800x800) though there have been ones smaller such as 400x360 which have broken in the same way.

There should really be an option to skip parsing images so those getting this issue can just bypass the image parsing and so this module will still be usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant