Convert to ESM #318
Merged
Convert to ESM #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronBuxbaum
approved these changes
Sep 16, 2021
| import { chalk } from '@4c/cli-core/ConsoleUtilities'; | ||
| import babel from '@babel/core'; | ||
| import { safeLoad } from 'js-yaml'; | ||
| import camelCase from 'lodash/camelCase.js'; |
There was a problem hiding this comment.
is there a good reason for these extensions? seems weird
There was a problem hiding this comment.
yes they are required for esm imports
There was a problem hiding this comment.
well not required for packages if the file is "main" or "exports" in the package.json sets it up. lodash doesn't set anything up
|
|
||
| exports.builder = (_) => | ||
| _.option('fix', { | ||
| export function builder(_) { |
There was a problem hiding this comment.
what's up with this argument being an underscore?
| return execa('git', ['tag', '-d', tag]); | ||
| } | ||
| export function getCurrentBranch(opts) { | ||
| return execa('git', ['rev-parse', '--abbrev-ref', 'HEAD'], opts).then( |
There was a problem hiding this comment.
any chance while we're touching this we can move from execa? might be better in a separate PR
There was a problem hiding this comment.
I don't want to move more things than necessary for this. i'm already pretty unsure i didn't break anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tired of not being able to ever update of of sindresorhus's packages which all do native esm now