Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of Params is incorrect #1057

Open
steinybot opened this issue Jan 31, 2024 · 0 comments · May be fixed by #1058
Open

Type of Params is incorrect #1057

steinybot opened this issue Jan 31, 2024 · 0 comments · May be fixed by #1058

Comments

@steinybot
Copy link

Params is:

export type Params = Record<string, string>;

But if you get an optional param that is missing you get undefined.

Either the type of Params should be:

export type Params = Record<string, string>;

Or the key for optional parameters should not be present.
steinybot added a commit to steinybot/found that referenced this issue Jan 31, 2024
@steinybot
fix: check matcher test types (4Catalyzer#1057)
f5d565d
steinybot added a commit to steinybot/found that referenced this issue Jan 31, 2024
@steinybot
fix: reproduce problem with params typing (4Catalyzer#1057)
2ce1eb6
steinybot added a commit to steinybot/found that referenced this issue Jan 31, 2024
@steinybot
fix: optional params may be undefined (4Catalyzer#1057)
ebde858
@steinybot steinybot linked a pull request Jan 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Param types steinybot/found
1 participant
@steinybot