Fix Param types #1058
Open
Fix Param types #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steinybot
commented
Jan 31, 2024
test/Matcher.test.ts
Outdated
|
|
||
| if (missingMatch != null && 0 in missingMatch.params) { | ||
| // FIXME: This type is wrong. It should be string | undefined. | ||
| const param: string = missingMatch.params[0]; |
There was a problem hiding this comment.
This shows what the problem was. The type is string but it is actually undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1057
I'm not sure if this is the idea solution. It maintains the same runtime behaviour but of course there is a breaking change in the types. Alternatively we could keep the types and change the behaviour so that missing params are not present in the object.