Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of children does not match basic example #1061

Open
steinybot opened this issue Feb 7, 2024 · 0 comments · May be fixed by #1062
Open

Type of children does not match basic example #1061

steinybot opened this issue Feb 7, 2024 · 0 comments · May be fixed by #1062

Comments

@steinybot
Copy link

The basic example has one of the children as:

        new Redirect({
          from: 'baz',
          to: '/foo',
        }),

If this is converted to TypeScript then it does not type check. The return type of Redrirect.render is ReactNode and not ResolvedElement | undefined.
steinybot added a commit to steinybot/found that referenced this issue Feb 7, 2024
@steinybot
fix: include ReactNode in render method result (4Catalyzer#1061)
04777aa
@steinybot steinybot linked a pull request Feb 7, 2024 that will close this issue
Open
steinybot added a commit to steinybot/found that referenced this issue Mar 6, 2024
@steinybot
fix: remove ReactNode from render method result (4Catalyzer#1061)
bafbdf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include ReactNode in render method result steinybot/found
1 participant
@steinybot