Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3916): support @@execute_mode = 'request' #3924

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aceforeverd
Copy link
Collaborator

close #3916

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels May 11, 2024
Copy link
Contributor

github-actions bot commented May 11, 2024

Linux Test Report

    59 files  ±0     252 suites  ±0   1h 40m 54s ⏱️ - 5m 22s
13 509 tests ±0  13 502 ✅ ±0  7 💤 ±0  0 ❌ ±0 
19 181 runs  ±0  19 174 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit e7bd756. ± Comparison against base commit 6569b42.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 11, 2024

SDK Test Report

102 files  ±0  102 suites  ±0   2m 12s ⏱️ -3s
357 tests ±0  343 ✅ ±0  14 💤 ±0  0 ❌ ±0 
483 runs  ±0  469 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit e7bd756. ± Comparison against base commit 6569b42.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 11, 2024

HybridSE Mac Test Report

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e7bd756.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 11, 2024

HybridSE Linux Test Report

20 362 tests   20 360 ✅  6m 10s ⏱️
   261 suites       2 💤
    68 files         0 ❌

Results for commit e7bd756.

♻️ This comment has been updated with latest results.

@aceforeverd aceforeverd force-pushed the feat-execute-mode-request branch 2 times, most recently from ee0ac85 to c7e2645 Compare May 11, 2024 04:36
@aceforeverd aceforeverd marked this pull request as draft May 11, 2024 05:19
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 75.17%. Comparing base (6569b42) to head (e7bd756).

Files Patch % Lines
hybridse/src/vm/engine.cc 77.77% 4 Missing ⚠️
src/sdk/internal/system_variable.cc 80.00% 3 Missing ⚠️
src/tablet/tablet_impl.cc 0.00% 3 Missing ⚠️
src/sdk/sql_cluster_router.cc 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main    #3924    +/-   ##
==========================================
  Coverage     75.16%   75.17%            
  Complexity      658      658            
==========================================
  Files           751      752     +1     
  Lines        135077   135104    +27     
  Branches       2038     1441   -597     
==========================================
+ Hits         101536   101564    +28     
+ Misses        33253    33252     -1     
  Partials        288      288            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for set @@execute_mode='request'; statement
1 participant