This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Add changes for chrome support #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested whether it works at all? |
|
Oh yes, sorry for not mentioning this in the PR. I tested on chrome and firefox and surprisingly both works well in my tests I first started doing the porting just for my use but it turned to work so well with not so much changes that I made this pull request. |
|
Cool, that's quite surprising. If I ever decide to pay the registration fee, at least there won't be much work additional work to be done. Thanks. |
|
@rowrawer Any chance to publish a |
|
I'll look into it. |
|
@rowrawer Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made two change for this to work on chrome, following the MDN guide building a cross-browser extension
Resolves #9