Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix HTML relatedConcepts for textbox and combobox
  • Loading branch information
jessebeach committed Nov 26, 2019
1 parent a5cf6b0 commit 4ce2a9e
Show file tree
Hide file tree
Showing 4 changed files with 272 additions and 4 deletions.
2 changes: 1 addition & 1 deletion flow/aria.js
Expand Up @@ -315,5 +315,5 @@ type ARIARoleRelationConceptAttribute = {
value?: string | number,
// Make these explicit. These values represent quirks of the mapping betweent
// ARIA and other semantic ontological systems.
constraints?: Array<'unset' | '>1'>,
constraints?: Array<'unset' | 'isset' | '>1'>,
};
110 changes: 108 additions & 2 deletions scripts/roles.json
Expand Up @@ -408,6 +408,78 @@
"value": 1
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "text"
}, {
"name": "list",
"constraints": ["isset"]
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "search"
}, {
"name": "list",
"constraints": ["isset"]
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "url"
}, {
"name": "list",
"constraints": ["isset"]
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "tel"
}, {
"name": "list",
"constraints": ["isset"]
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "url"
}, {
"name": "list",
"constraints": ["isset"]
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "email"
}, {
"name": "list",
"constraints": ["isset"]
}]
}
}, {
"module": "XForms",
"concept": {
Expand Down Expand Up @@ -4432,15 +4504,49 @@
}, {
"module": "HTML",
"concept": {
"name": "input"
"name": "input",
"attributes": [{
"name": "type",
"value": "text"
}, {
"name": "list",
"constraints": ["unset"]
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "text"
"value": "email"
}, {
"name": "list",
"constraints": ["unset"]
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "tel"
}, {
"name": "list",
"constraints": ["unset"]
}]
}
}, {
"module": "HTML",
"concept": {
"name": "input",
"attributes": [{
"name": "type",
"value": "url"
}, {
"name": "list",
"constraints": ["unset"]
}]
}
}],
Expand Down
108 changes: 108 additions & 0 deletions src/etc/roles/literal/comboboxRole.js
Expand Up @@ -55,6 +55,114 @@ const comboboxRole: ARIARoleDefinition = {
],
},
},
{
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'text',
},
{
name: 'list',
constraints: [
'isset',
],
},
],
},
},
{
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'search',
},
{
name: 'list',
constraints: [
'isset',
],
},
],
},
},
{
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'url',
},
{
name: 'list',
constraints: [
'isset',
],
},
],
},
},
{
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'tel',
},
{
name: 'list',
constraints: [
'isset',
],
},
],
},
},
{
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'url',
},
{
name: 'list',
constraints: [
'isset',
],
},
],
},
},
{
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'email',
},
{
name: 'list',
constraints: [
'isset',
],
},
],
},
},
{
module: 'XForms',
concept: {
Expand Down
56 changes: 55 additions & 1 deletion src/etc/roles/literal/textboxRole.js
Expand Up @@ -34,6 +34,18 @@ const textboxRole: ARIARoleDefinition = {
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'text',
},
{
name: 'list',
constraints: [
'unset',
],
},
],
},
},
{
Expand All @@ -43,7 +55,49 @@ const textboxRole: ARIARoleDefinition = {
attributes: [
{
name: 'type',
value: 'text',
value: 'email',
},
{
name: 'list',
constraints: [
'unset',
],
},
],
},
},
{
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'tel',
},
{
name: 'list',
constraints: [
'unset',
],
},
],
},
},
{
module: 'HTML',
concept: {
name: 'input',
attributes: [
{
name: 'type',
value: 'url',
},
{
name: 'list',
constraints: [
'unset',
],
},
],
},
Expand Down

0 comments on commit 4ce2a9e

Please sign in to comment.