Fix mapping for the HTML select element

A11yance · Nov 26, 2019 · c3c510d · c3c510d
1 parent 900cfd9
commit c3c510d
Show file tree

Hide file tree

Showing 4 changed files with 142 additions and 3 deletions.
diff --git a/flow/aria.js b/flow/aria.js
@@ -312,5 +312,8 @@ type ARIARoleRelationConcept = {
 
 type ARIARoleRelationConceptAttribute = {
   name: string,
-  value?: string,
+  value?: string | number,
+  // Make these explicit. These values represent quirks of the mapping betweent
+  // ARIA and other semantic ontological systems.
+  constraints?: Array<'unset' | '>1'>,
 };
diff --git a/scripts/breakUpAriaJSON.js b/scripts/breakUpAriaJSON.js
@@ -94,6 +94,9 @@ function triageValue(value, depth = 0) {
     case 'string':
       output = output.concat(`\'${value}\'`);
       break;
+    case 'number':
+      output = output.concat(`${value}`);
+      break;
     default:
       output.push('null');
   }

diff --git a/scripts/roles.json b/scripts/roles.json
@@ -4038,7 +4038,59 @@
     "abstract": true,
     "childrenPresentational": false,
     "baseConcepts": [],
-    "relatedConcepts": []
+    "relatedConcepts": [{
+      "module": "ARIA",
+      "concept": {
+        "name": "combobox",
+        "attributes": [{
+          "name": "multiple",
+          "constraints": ["unset"]
+        }, {
+          "name": "size",
+          "constraints": ["unset"]
+        }]
+      }
+    }, {
+      "module": "ARIA",
+      "concept": {
+        "name": "combobox",
+        "attributes": [{
+          "name": "multiple",
+          "constraints": ["unset"]
+        }, {
+          "name": "size",
+          "value": 1
+        }]
+      }
+    }, {
+      "module": "ARIA",
+      "concept": {
+        "name": "listbox",
+        "attributes": [{
+          "name": "multiple"
+        }]
+      }
+    }, {
+      "module": "ARIA",
+      "concept": {
+        "name": "listbox",
+        "attributes": [{
+          "name": "multiple"
+        }, {
+          "name": "size",
+          "constraints": [">1"]
+        }]
+      }
+    }, {
+      "module": "ARIA",
+      "concept": {
+        "name": "listbox",
+        "attributes": [{
+          "name": "size",
+          "constraints": [">1"]
+        }]
+      }
+    }]
   },
   "separator": {
     "superClass": ["structure"],

diff --git a/src/etc/roles/abstract/selectRole.js b/src/etc/roles/abstract/selectRole.js
@@ -12,7 +12,88 @@ const selectRole: ARIARoleDefinition = {
   props: {
     'aria-orientation': null,
   },
-  relatedConcepts: [],
+  relatedConcepts: [
+    {
+      module: 'ARIA',
+      concept: {
+        name: 'combobox',
+        attributes: [
+          {
+            name: 'multiple',
+            constraints: [
+              'unset',
+            ],
+          },
+          {
+            name: 'size',
+            constraints: [
+              'unset',
+            ],
+          },
+        ],
+      },
+    },
+    {
+      module: 'ARIA',
+      concept: {
+        name: 'combobox',
+        attributes: [
+          {
+            name: 'multiple',
+            constraints: [
+              'unset',
+            ],
+          },
+          {
+            name: 'size',
+            value: 1,
+          },
+        ],
+      },
+    },
+    {
+      module: 'ARIA',
+      concept: {
+        name: 'listbox',
+        attributes: [
+          {
+            name: 'multiple',
+          },
+        ],
+      },
+    },
+    {
+      module: 'ARIA',
+      concept: {
+        name: 'listbox',
+        attributes: [
+          {
+            name: 'multiple',
+          },
+          {
+            name: 'size',
+            constraints: [
+              '>1',
+            ],
+          },
+        ],
+      },
+    },
+    {
+      module: 'ARIA',
+      concept: {
+        name: 'listbox',
+        attributes: [
+          {
+            name: 'size',
+            constraints: [
+              '>1',
+            ],
+          },
+        ],
+      },
+    },
+  ],
   requireContextRole: [],
   requiredContextRole: [],
   requiredOwnedElements: [],