Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisclosureTriangleRole model wrong? #319

Closed
dummdidumm opened this issue Jun 28, 2023 · 7 comments
Closed

DisclosureTriangleRole model wrong? #319

dummdidumm opened this issue Jun 28, 2023 · 7 comments

Comments

@dummdidumm
Copy link

In #273 the DisclosureTriangleRole model was adjusted and constraints/attributes were added. If I'm understanding this correctly, that means that a <summary> tag now either needs a open or aria-expanded attribute, but both these AFAIK should be on the parent <details> tag instead. So if I'm understanding this correctly, the DisclosureTriangleRole model should instead be reduced to

const DisclosureTriangleRole: AXObjectModelDefinition = {
  relatedConcepts: [
    {
      module: 'HTML',
      concept: {
        constraints: [
          'scoped to a details element',
        ],
        name: 'summary',
      },
    },
  ],
  type: 'widget',
};

It could also very well be that I'm understanding the semantic meaning of attributes incorrectly, in which case could you briefly explain what it means?

elycheea added a commit to carbon-design-system/ibm-products that referenced this issue Jul 12, 2023
summary incorrectly flagged as non-interactive
A11yance/axobject-query/issues/319
elycheea added a commit to carbon-design-system/ibm-products that referenced this issue Jul 12, 2023
* chore: update dev dependencies

* chore: update gallery

* chore: remove useWorkspaces

https://github.com/lerna/lerna/releases/tag/7.0.0
Ran `lerna repair`

* chore: rollback framer

* chore: fix jsx-a11y in OptionsTile

summary incorrectly flagged as non-interactive
A11yance/axobject-query/issues/319

---------

Co-authored-by: lee-chase <lee-chase@users.noreply.github.com>
Co-authored-by: Elysia Hwang <Elysia.Hwang@ibm.com>
@jessebeach
Copy link
Member

Here is the summary html element spec for future reference: https://html.spec.whatwg.org/multipage/interactive-elements.html#the-summary-element

@jessebeach
Copy link
Member

It looks like the summary element is mapped to the DisclosureTriangle concept.

Screenshot 2023-08-12 at 9 27 21 PM

@jessebeach
Copy link
Member

@dummdidumm your proposal is correct.

@jessebeach
Copy link
Member

Fixed in #339

@dummdidumm
Copy link
Author

@jessebeach sorry to ping - when can we expect this to get released?

@jessebeach
Copy link
Member

I'll try to get a release out on Sunday.

@jessebeach
Copy link
Member

@dummdidumm I just published v4.0.0: https://www.npmjs.com/package/axobject-query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants