Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hard coded region #172

Closed
wants to merge 1 commit into from

Conversation

Danwakeem
Copy link

@Danwakeem Danwakeem commented Sep 3, 2021

What did you implement:

Closes #171

How did you implement it:

I removed the hard coded us-east-1 configurations

How can we verify it:

Check that you do not see any more AWS.config.updates in the app 😎 or run an ssm update/create in a region other than us-east-1 and make sure they show up in the appropriate region.

Todos:

  • Write tests - 🤷‍♂️
  • Write documentation - If you would like me to add anything for this just let me know 👍
  • Fix linting errors
  • Provide verification config/commands/resources

@Danwakeem
Copy link
Author

Yo @kyle-ruan do you think this would be alright to support multi region deployments? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region hard coded to us-east-1
1 participant