New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows-build: Fail to build packages in PR #4225

Open

outloudvi opened this issue Sep 29, 2022 · 1 comment

Assignees

Labels

workflow

Contributor

outloudvi commented Sep 29, 2022

Currently the workflow cannot build PRs: Sample log for #4224.

Long story long, read this GitHub blog.

Long story short:

Git v2.35.2 workarounds CVE-2022-24765 by safe.directory.
actions/checkout workarounds safe.directory by creating user-wide .gitconfig (this config doesn't work in repo-wide .gitconfig) - that's why it worked.
To avoid flushing .gitconfig on self-hosted runners, actions/checkout uses a temporary home directory to put user .gitconfig.
gh CLI apparently isn't aware of that temporary .gitconfig - that's why it failed.

The most simple solution: set user-wide actions/checkout in the runner - we don't use self-hosted runners for now on aosc-os-abbs.

The simple and robust solution: use actions/checkout to check out PRs.

See-Also: actions/checkout#762

The text was updated successfully, but these errors were encountered:

outloudvi added the workflow label

outloudvi self-assigned this

Contributor Author

outloudvi commented Oct 4, 2022

cc @KexyBiscuit for vis - which method (or other solution) would you recommend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment