Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected "get" requests in generated openapi spec #30

Open
sverch opened this issue Mar 8, 2020 · 2 comments
Open

Unexpected "get" requests in generated openapi spec #30

sverch opened this issue Mar 8, 2020 · 2 comments

Comments

@sverch
Copy link

sverch commented Mar 8, 2020

The source spec for this doesn't have any mention of "GET" as far as I can tell, but the generated result has a "POST" and "GET" equivalent for every API call. I would expect just the "POST" version to show up because that's what's actually in the original definition.

It also causes some generation errors, which I think is because the generated code is trying to set query parameters from an object that it doesn't know how to turn into a string. For example:

error[E0599]: no method named `to_string` found for type `&models::tag::Tag` in the current scope
@MikeRalphson
Copy link
Contributor

See #17

I think your issues with generated code are a separate issue though. I'm unsure why the type is not stringifiable from what you have posted.

@sverch
Copy link
Author

sverch commented Mar 9, 2020

Thanks for the link! That's interesting. I didn't know AWS explicitly supported both.

Maybe a basic question, but for compound types like a list of tags, how should they be serialized into parameters for a get request? The docs that the issue you linked to link to don't really mention that case.

Also, I do see the usage of toGet mentioned in that issue here. Looks like maybe the sdk supports both, and uses get for presigned urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants