Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to build on non-RHEL distros #423

Closed
1 task done
lithorus opened this issue Mar 26, 2024 · 0 comments · Fixed by #424
Closed
1 task done

[Bug]: Unable to build on non-RHEL distros #423

lithorus opened this issue Mar 26, 2024 · 0 comments · Fixed by #424
Labels
bug Something isn't working

Comments

@lithorus
Copy link
Contributor

What happened?

Cmake checks for RHEL distro and quits if it's a non-RHEL distro. Have created PR which removes the blocking of other distros and have adjusted the dependecies accordingly.

List all the operating systems versions where this is happening

Ubuntu 20.04

On what computer hardware is this happening?

x86_64

Relevant console log output

No response

Environment variables

No response

Extra information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lithorus lithorus added the bug Something isn't working label Mar 26, 2024
bernie-laberge added a commit that referenced this issue May 29, 2024
Fixes #423

### Summarize your change.
Have removed the blocking of trying to build on non-RHEL distro and
changed to only use lib64 on RHEL distros.

### Describe the reason for the change.
Unable to build on eg. Ubuntu

### Describe what you have tested and on which operating system.
Have tested with Ubuntu 20.04 using a custom build of Qt5 (and rest is
standard repo packages)

### Add a list of changes, and note any that might need special
attention during the review.
Have not (yet) tested on a RHEL distro, but have made changes that
differentiate between RHEL and non-RHEL Linux distros

---------

Signed-off-by: Jimmy Christensen <lithorus@gmail.com>
Co-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant