Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"illuminant" and "type" attributes are not described in "JSON Schema for Spectral Datasets". #114

Open
KelSolaar opened this issue Aug 19, 2019 · 0 comments

Comments

@KelSolaar
Copy link
Contributor

Hi,

I just noticed that the illuminant and type attributes are not described in the JSON Schema for Spectral Datasets:

So we end up with the following attribute specificities:

  • camera: manufacturer, model
  • cmfs: type
  • illuminant: illuminant
  • training: type

It is not super consistent and not very generic, it is also very odd to have illuminant: illuminant and cmfs: type, should both the same a way or another for consistency.

Maybe using type for everything is the way to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant