feat: Fixed footerUI , added twitter link #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaDawsonDev
requested changes
May 6, 2023
There was a problem hiding this comment.
Hi Arslan, thanks for making a PR. I would've preferred to see a mockup as I suggested in the issue because that way we could've discussed the design before committing anything to code.
I am not keen on the links being centralised in a long list like this, I think they take up too much space and leave to much white space either side, which is why they were originally spread out on one line. I think we need to iterate on the design of this section a bit more before merging.
I do however appreciate that you added the twitter link and would like to keep that.
Co-authored-by: Emma Dawson <emma.l.dawson@gmail.com>
|
@EmmaDawsonDev Makes sense, thanks for the review. Will be posting a mockup soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Made the footer better looking , added twitter link to @EmmaDawsonDev. fixed responsiveness of footer for mobile/Ipads.
Screenshots -
Link to issue
closes #288
Checklist before requesting a review
and it shows no errors.