Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add searchbar #373

Closed
wants to merge 6 commits into from
Closed

Add searchbar #373

wants to merge 6 commits into from

Conversation

DIWAKARKASHYAP
Copy link
Contributor

Describe your changes

Screenshots - If Any (Optional)

image
image

Link to issue

Closes #300

Checklist before requesting a review

  • I have performed a self-review of my code.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.
  • I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
    and it shows no errors.

Additional Information (Optional)

Any additional information that you want to give us.

@DIWAKARKASHYAP
Copy link
Contributor Author

@EmmaDawsonDev please check

@EmmaDawsonDev
Copy link
Member

Hi @DIWAKARKASHYAP I know you've gone to some effort to make this pull request but it wasn't assigned and therefore I'm not going to accept it. We need to find a good (preferably open source and low cost) way to search through the content of the pages, not just remove things from the navigation which is why the issue has a lot of discussion surrounding it.

@DIWAKARKASHYAP
Copy link
Contributor Author

Hi @DIWAKARKASHYAP I know you've gone to some effort to make this pull request but it wasn't assigned and therefore I'm not going to accept it. We need to find a good (preferably open source and low cost) way to search through the content of the pages, not just remove things from the navigation which is why the issue has a lot of discussion surrounding it.

Ok , thanks for your response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navbar or Searchbar Enhancement
2 participants
@DIWAKARKASHYAP @EmmaDawsonDev