fix: close mobile nav on blur of nav list #380
Conversation
|
Hey, @EmmaDawsonDev |
There was a problem hiding this comment.
Hi Satyam,
I'm not sure all the refactoring/name changing was really necessary. In the future it would be better to discuss these possible changes before going ahead and making them. I prefer to keep pull requests small and focused on one thing. The refactoring should be a separate pull request if it's decided that it's a needed change.
With regards to the navigation bug. It now closes as expected when tabbing forwards. However, if you tab to the last item and then choose to shift+tab to go backwards it also triggers the nav to close and this is not the expected behaviour.
| }: INavProps) => { | ||
| const handleNavBlur = useCallback((event: FocusEvent<HTMLAnchorElement>) => { | ||
| const isLastNavItem = /true/i.test(event.target.dataset?.lastNavItem ?? "") |
There was a problem hiding this comment.
I'm not really sure what's going on in this line. I've not seen this syntax before. Can you explain what's happening?
Describe your changes
This PR contains 2 changes as follows -
Link to issue
Closes #379
Checklist before requesting a review
and it shows no errors.
Additional Information (Optional)
Any additional information that you want to give us.