Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default colors #16

Open
xendk opened this issue Apr 7, 2018 · 2 comments
Open

Default colors #16

xendk opened this issue Apr 7, 2018 · 2 comments

Comments

@xendk
Copy link
Contributor

xendk commented Apr 7, 2018

As a new user, I found the default coloring confusing. red/green for not-covered/covered makes sense, but red for much covered and green for not so much?

I do like the heavy/med/light coloring mode, I haven't seen that elsewhere, but I think it should follow the color convention of the covered/not-covered. May I suggest red/orange/yellow/green for none/light/med/heavy?

(and I'd like a quick toogle for using backgrounds instead of fringes, but that's another story)

@AdamNiederer
Copy link
Owner

AdamNiederer commented Apr 7, 2018

Hm, maybe red/green/light-green/white or red/green/teal/blue would work for heatmap-style highlighting. That would preserve the "red is bad; green is good" idea in the fringe, but also provide the user with the heatmap data. We might even be able to tint it linearly/logarithmically based on the data, rather than arbitrary thresholds.

@ardumont
Copy link

I was confused as @xendk expressed ¯_(ツ)_/¯.

But as it's customizable, here is my take on this. In your emacs
configuration routines, you can put the following:

(custom-set-faces
 '(cov-none-face  ((((class color)) :foreground "red")))
 '(cov-light-face ((((class color)) :foreground "orange")))
 '(cov-med-face   ((((class color)) :foreground "yellow")))
 '(cov-heavy-face ((((class color)) :foreground "green"))))

No idea if it's a good idea long term but others might find
this helpful nonetheless.

Thanks for the work on this btw ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants