Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Selected <li> tabindex #219

Closed
mokkrb opened this issue Jun 20, 2018 · 2 comments
Closed

Accessibility Selected <li> tabindex #219

mokkrb opened this issue Jun 20, 2018 · 2 comments

Comments

@mokkrb
Copy link

mokkrb commented Jun 20, 2018

I am running through some accessibility checks and I have notices this piece of code:

<li class="selected"><a tabindex="0" aria-label="Page 3 is your current page" aria-current="page">3</a></li>

The issue with that is there is no action set on the "selected" li. So when running through the page with Tab, I can see the previous, and next button selectable (and pressing enter will trigger the expected behaviour).
Is there a way to make the tabindex="-1" for the selected link ? I don't think there is any need to make it selectable, specially if no action can be performed on it.

Thanks in advance

@GLosch
Copy link

GLosch commented Aug 31, 2021

I have a similar request for setting tabIndex="-1" for the Previous/Next buttons when they're disabled. Happy to contribute.

@MonsieurV
Copy link
Collaborator

Related #273.

Thanks for the suggestion @mokkrb @GLosch. This will be released on the v7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants