Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong numbering in pagination #395

Closed
csl24 opened this issue Nov 19, 2021 · 5 comments
Closed

Wrong numbering in pagination #395

csl24 opened this issue Nov 19, 2021 · 5 comments

Comments

@csl24
Copy link

csl24 commented Nov 19, 2021

Hello!

When testing the library, I noticed that the page numbering is not correct in some cases.

error

I found that the error is related to the implementation "Fix the breaking algorithm to not create breaks for only one page" (see: #270) in the v8.0.0, because in v7.1.3 there is no problem of enumeration.

I add a link to test the behavior: codepen

@progranime
Copy link

Hi,

I've encountered the same issue.
I'm using this version.
"react-paginate": "^8.0.0"

image
image

Please check on this issue.
Thanks.

@MonsieurV
Copy link
Collaborator

Indeed, it was utterly broken. 😬
I didn't tested it properly with many pages.

Thanks for the report @csl24 @progranime

@MonsieurV
Copy link
Collaborator

You can test right now the fix with:

npm install --save github:AdeleD/react-paginate#v8.0.1

https://github.com/AdeleD/react-paginate/releases/tag/v8.0.1
@AdeleD this could be released, as v8.0.0 is pretty broken

@AdeleD
Copy link
Owner

AdeleD commented Nov 24, 2021

@MonsieurV Done

@MonsieurV
Copy link
Collaborator

MonsieurV commented Nov 24, 2021

Thx @AdeleD

Here the original snippet with the bug fixed (react-paginate bumped to v8.0.1): https://codepen.io/monsieurv/pen/MWvMOBE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants