Flag for updating from the command line

[ainar-g]

(Split from #4219).

We need a command line flag to perform an update without the need to enable / use the Web API. Something like ./AdGuardHome --update.

[Vexz00]

How exactly does this work now? I use the --update option and the console seems to be stuck doing nothing.
Shouldn't it be checking for an update and if there is no update available telling something like "There's no new update." or something? It's confusing to me.

Edit:
I think I get it now. It starts an instance of AGH with automatic silent updates, right? Will I experience timeouts for DNS queries during an update of AGH or is the update fast enough to not run into timeouts?

Edit 2:
So here the description for the --update argument is "Update application and exit.". What does "and exit" exactly mean here? Does it stop the AGH service? I don't see why anyone would want that. But I can't think of anything else what "and exit" would mean.

[webmihir]

How exactly does this work now? I use the --update option

Same question. I am trying to see if I can integrate this into a nightly CRON job by calling /opt/AdguardHome/AdguardHome --update. However similar to the previous poster's observation, the console is stuck and never returns.

[Vexz00]

I am trying to see if I can integrate this into a nightly CRON job by calling /opt/AdguardHome/AdguardHome --update.

That was exactly my plan but I think it's just an argument when launching AGH and it will automatically update AGH when it finds an update. Not quite what I was looking for because I don't want to run into DNS query timeouts when I actively need AGH during the day.

[elandorr]

Same here. The description in --help says it will update and exit, but it does literally nothing.

My 'workflow' is as follows for windows clients if anyone cares:

1. see new stable on git
2. download
3. verify sig
4. AdGuardHome.exe -s uninstall
5. replace file
6. AdGuardHome -s install --no-check-update (installs the service with -s run --no-check-update)

Automatic connections are unwanted here.

An improvement would be:

1. see new stable on git
2. run AdGuardHome.exe --update
3. agh downloads and verifies the signature
4. agh replaces itself and keeps the --no-check-update flag for the service

Cheers

[wesley800]

LOL seems not usable at all. I'm stucked too.

Actually, for the update to successfully run (at least on Linux), one must shutdown any running AdGH instance. Otherwise the code will stuck at bbolt.Open. To be more specific, bbolt is designed to not allow multiple instance. See bbolt/db.go:230:if err := flock(db, !db.readOnly, options.Timeout); err != nil { and the comment above it for details.

BTW debugging with GDB on golang program is more than painful with the totally-no-accuracy breakpoints.

@ainar-g Would you please reopen this issue?

[EugeneOne1]

@Vexz00, @webmihir, @elandorr, @wesley800, hello again. We've published the edge release which should fix the --update flag. Could you please check it out? Also keep in mind that the proper update needs the next release to be published, however AdGuard Home now shouldn't freeze even in case the release is absent.

[EugeneOne1]

Well, I'll close the issue for now if you don't mind, since we've been able to succesfully test it on our machines. Please feel free to reopen it if you'll face any issues with our fixed implementation.

[webmihir]

Well, I'll close the issue for now if you don't mind, since we've been able to succesfully test it on our machines. Please feel free to reopen it if you'll face any issues with our fixed implementation.

I'm sorry I forgot to respond over there long weekend. Yes I can confirm this is working on edge. Looking forward to this making it's way to 108 along with the actual fix!

[elandorr]

Thanks, I'll test it on the next update as well!

[Vexz00]

Sorry for the late reply. I tried it earlier today and it looks like it would work if there was a new update available.

But I have one question left: Will it update an already running instance of AGH so we can make a cron job to automatically update and completely forget about it? This would be a dream come true since this would mean I wouldn't have to do anything anymore and AGH is always up to date.

[EugeneOne1]

@Vexz00, it'll actually only try to restart the service if the one installed.

[elandorr]

I tested it today with the new update.

• If run with root permissions, the service definition is not touched, so the --no-check-update stays intact.
• If run without root permissions, the error message about the service is wrong, but it couldn't know any better. It did finish and replace the binary I think, but it can't have restarted the service, so it'll probably crash sooner or later.

Seems like it works fine. You can update when you explicitly want to update, without additional unwanted network activity, and without manually visiting github/unpacking/etc.

Does this verify signature based on the initial binary, though? That seems pretty critical.

We set it up once, verify your sig, and it then continues to rotate. Otherwise, if you're ever taken over, having this without human oversight seems risky. If you do it manually, there's a bigger chance you may notice the github repo is weird.

[ainar-g]

@elandorr, please file a separate issue about that.

[elandorr]

About what? This is just the promised feedback for when there's a new update.

[Vexz00]

@Vexz00, it'll actually only try to restart the service if the one installed.

And that's fine because with the start of the service an instance of AGH is started too. That means when there's a new update it'll install the update and restart the service which also restarts AGH. Everything is working fine this way. Only a manually started instance of AGH doesn't get restarted.