Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clear DNS Cache Button in DNS Settings #5190

Closed
3 tasks done
L8X opened this issue Nov 25, 2022 · 4 comments
Closed
3 tasks done

Add Clear DNS Cache Button in DNS Settings #5190

L8X opened this issue Nov 25, 2022 · 4 comments
Assignees
@IldarKamalov @ainar-g
Labels
feature request P3: Medium
Milestone
v0.107.20

Comments

@L8X
Copy link

L8X commented Nov 25, 2022

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

Description

What problem are you trying to solve?

Clearing cache currently requires restarting or setting cache size to 0 and back to the old number, which is tedious.

Proposed solution

Add a clear cache button under DNS Settings that will purge the cache file of AGH.

Alternatives considered

There are no realistic or simpler alternatives.

Additional information

N/A
@whyisthisbroken
Copy link

whyisthisbroken commented Nov 26, 2022 •
edited

Would be also nice to see how much entries are inside the cache or size like MB.
The beta dashboard has something like this but the development feels discontinued.
The cache feature is nice but no one can see any stats. I mean, stats are essential within a server program or not :)

@ainar-g
Copy link
Contributor

ainar-g commented Dec 1, 2022

See also #4695.

adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Dec 1, 2022
@ainar-g
Pull request: 5190-clear-cache
7aa32db 
Updates AdguardTeam/AdGuardHome#4695.
Updates AdguardTeam/AdGuardHome#5190.

Squashed commit of the following:

commit 535edd8
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 1 18:23:15 2022 +0300

    proxy: use mutexes better

commit fe301f4
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 1 18:11:59 2022 +0300

    proxy: add cache clear api
@ainar-g ainar-g self-assigned this Dec 1, 2022
@ainar-g ainar-g added this to the v0.107.20 milestone Dec 1, 2022
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Dec 2, 2022
@ainar-g
Pull request: 5190-fix-panic
6d9de39 
Updates AdguardTeam/AdGuardHome#4695.
Updates AdguardTeam/AdGuardHome#5190.

Squashed commit of the following:

commit 881fbc0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Dec 2 15:28:47 2022 +0300

    proxy: fix panic
adguard pushed a commit that referenced this issue Dec 2, 2022
@ainar-g
Pull request: 5190-clear-cache
09f88cf 
Updates #4695.
Updates #5190.

Squashed commit of the following:

commit f4156f5
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Dec 2 16:19:03 2022 +0300

    client: button styles

commit 42cd8ac
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Dec 2 15:39:15 2022 +0300

    all: upd dnsproxy

commit 87b0439
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Dec 2 15:19:07 2022 +0300

    client: add clear cache button

commit ee99548
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 1 18:54:54 2022 +0300

    all: add cache clear
@ainar-g
Copy link
Contributor

ainar-g commented Dec 2, 2022

This is implemented as of v0.108.0-a.391+09f88cf2 on the Edge channel. Can you please check if the new feature works for you?

@L8X
Copy link
Author

L8X commented Dec 4, 2022

This is implemented as of v0.108.0-a.391+09f88cf2 on the Edge channel. Can you please check if the new feature works for you?

This works amazingly. Thank you AdGuard Team for your amazing work!

@ainar-g ainar-g closed this as completed Dec 7, 2022
@ainar-g ainar-g modified the milestones: v0.107.21, v0.107.20 Dec 7, 2022
@ammnt ammnt mentioned this issue Feb 2, 2023
Closed
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: 5190-clear-cache
226c4a6 
Updates AdguardTeam#4695.
Updates AdguardTeam#5190.

Squashed commit of the following:

commit f4156f5
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Dec 2 16:19:03 2022 +0300

    client: button styles

commit 42cd8ac
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Dec 2 15:39:15 2022 +0300

    all: upd dnsproxy

commit 87b0439
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Dec 2 15:19:07 2022 +0300

    client: add clear cache button

commit ee99548
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 1 18:54:54 2022 +0300

    all: add cache clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IldarKamalov IldarKamalov

@ainar-g ainar-g

Labels
feature request P3: Medium
Projects
None yet
Milestone
v0.107.20
Development

No branches or pull requests
4 participants
@IldarKamalov @ainar-g @L8X @whyisthisbroken