Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range of IP addresses validation issue #5208

Closed
3 tasks done
Versty opened this issue Nov 28, 2022 · 0 comments
Closed
3 tasks done

Range of IP addresses validation issue #5208

Versty opened this issue Nov 28, 2022 · 0 comments
Assignees
@EugeneOne1
Labels
bug P4: Low
Milestone
v0.107.20

Comments

@Versty
Copy link

Versty commented Nov 28, 2022

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, OpenWrt

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.107.19

Description

What did you do?

While configuring DHCP server, set the start of range of IP addresses equal to the gateway IP

Expected result

Error: Gateway IP must be out of the selected range of IP addresses

Actual result

Error: Must be lower than range start
@ainar-g ainar-g added this to the v0.107.20 milestone Dec 1, 2022
@adguard adguard closed this as completed in f0cf6cc Dec 7, 2022
@ainar-g ainar-g modified the milestones: v0.107.21, v0.107.20 Dec 7, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 5208-dhcp-range
68cd6e4 
Merge in DNS/adguard-home from 5208-dhcp-range to master

Closes AdguardTeam#5208.

Squashed commit of the following:

commit b7bd646
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Dec 6 18:55:03 2022 +0300

    client: restore non-en locales

commit 8e30620
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Dec 6 18:45:51 2022 +0300

    client: rm unused locales

commit 087cf2e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Dec 6 18:25:54 2022 +0300

    all: log changes

commit f1f9d79
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Dec 6 18:23:06 2022 +0300

    client: imp dhcp err msgs

commit b9d8d70
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Dec 6 15:44:44 2022 +0300

    WIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P4: Low
Projects
None yet
Milestone
v0.107.20
Development

No branches or pull requests
3 participants
@ainar-g @EugeneOne1 @Versty