Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules count is reset to 0 after editing DNS blocklist/allowlist URL #5290

Closed
3 tasks done
Versty opened this issue Dec 21, 2022 · 0 comments
Closed
3 tasks done

Rules count is reset to 0 after editing DNS blocklist/allowlist URL #5290

Versty opened this issue Dec 21, 2022 · 0 comments
Assignees
@EugeneOne1
Labels
bug P3: Medium
Milestone
v0.107.22

Comments

@Versty
Copy link

Versty commented Dec 21, 2022

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

FreeBSD

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

0.107.21

Description

Steps to reproduce

  1. Add new DNS blocklist
  2. Click the Edit button
  3. Change one letter in the blocklist's URL
  4. Press Save
  5. Error control/filtering/set_url | got status code != 200: 404 | 400 is shown
  6. Click the Cancel button
  7. Refresh page

Expected result

No changes in the blocklist's URL, the rules counter shows the actual number of rules in the filter

Actual result

Rules counter is set to 0, but the rules keep working
@Versty Versty added this to the v0.107.22 milestone Dec 21, 2022
@ainar-g ainar-g modified the milestones: v0.107.23, v0.107.22 Jan 19, 2023
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 5290-rules-count
b8eff4a 
Merge in DNS/adguard-home from 5290-rules-count to master

Closes AdguardTeam#5290.

Squashed commit of the following:

commit c29fd66
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Dec 23 14:42:57 2022 +0400

    all: log changes

commit fba4fe7
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Dec 23 14:33:57 2022 +0400

    filtering: fix rules count on err
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.107.22
Development

No branches or pull requests
3 participants
@ainar-g @EugeneOne1 @Versty