Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentBuilder for Replication Serializer #44

Open
dlh3 opened this issue May 10, 2016 · 4 comments
Open

ContentBuilder for Replication Serializer #44

dlh3 opened this issue May 10, 2016 · 4 comments

Comments

@dlh3
Copy link
Contributor

dlh3 commented May 10, 2016

I nominate Matthias Wermund's (Acquity Group part of Accenture) ContentBuilder implementation to be included as a sample Replication Serializer:
https://github.com/mwmd/circuit14-aem-replication/tree/master/bundle/src/main/java/com/wmd/serialization/impl

Related SlideShare deck with other potential samples:
http://www.slideshare.net/mwmd/adobe-experience-manager-replication-deep-dive

@davidjgonzalez
Copy link
Contributor

@dlh3 any reason why the Builder couldnt use https://sling.apache.org/apidocs/sling6/org/apache/sling/commons/json/jcr/JsonItemWriter.html ? seems more straight forward that making fake request/response objs?

That being said, having a suite of commonly used replication extensions would be nice.

@dlh3
Copy link
Contributor Author

dlh3 commented May 12, 2016

No reason that I'm aware of. Perhaps @mwmd could comment, as it was his code, not mine.

@davidjgonzalez
Copy link
Contributor

@dlh3 I think if we pull this we should update the code to use the Json writer API which makes its reasonably different from the current Impl. May be easier to just write from scratch?

@dlh3
Copy link
Contributor Author

dlh3 commented May 16, 2016

Reimplemented with the JSON Writer API and created PR #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants