-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/edit an adventure #20
Comments
I haven't worked on this directly, but I have already worked on serializing objects which allow for easy transforming from JSON to object (and vice versa), and would make this much easier. So If someone wants to jump on this asap, I can do a PR for my serializer. |
Make a PR, so we can see the progress and start working on this. |
Are we planning on using Serializing objects? I thought we decided against them since they have unnecessary overhead. |
I wasn't aware of that. Must've missed the discussion on Discord. |
Well comparing #23 to my serializing objects version, I find the PR to be much simpler and cleaner. I could push my code so that we can compare. |
Do we have a final decision on whether we're requiring user login for this? If so, does an endpoint for that need doing first? |
The current plan is to have a login for this. I am not sure what it would take to implement that. |
I'd be happy to give this a shot, my main worry is doing authentication and/or CSRF protection wrong. |
Well probably do OAuth IIRC, so that'll need to be implemented, but I think it should be a part of the parent view that handles generic requests. The CRUD views will inherit from that generic JSONResponse view that will also provide authentication wherever necessary.. |
I'm starting to work on adding adventures. How are we handling authors? Do we create a new Author object for authors we don't recognise? That seems like the most sane thing to do to me, but I might be wrong. |
Have an api that can add/edit information about an adventure to our database.
The text was updated successfully, but these errors were encountered: