Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AdditionalData lacks the field paymentLinkId #787

Closed
SergioBergaminiCodeploy opened this issue Oct 19, 2021 · 3 comments
Closed

[BUG] AdditionalData lacks the field paymentLinkId #787

SergioBergaminiCodeploy opened this issue Oct 19, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@SergioBergaminiCodeploy
Copy link
Contributor

Describe the bug
As far as I understand the APIs implementation by reading issue #494, to deserialize a webhook notification the class NotificationRequest must be used. So far so good. For this kind of deserialization to work, each field must be manually mapped which is of course a process prone to errors.

For example, the class AdditionalData lacks the field paymentLinkId which is quite important and should be there based on the documentation (see https://docs.adyen.com/unified-commerce/pay-by-link/payment-links/api#notification).

@SergioBergaminiCodeploy SergioBergaminiCodeploy added the bug Something isn't working label Oct 19, 2021
SergioBergaminiCodeploy added a commit to codeploy-srl/adyen-node-api-library that referenced this issue Oct 19, 2021
@wboereboom
Copy link
Contributor

HI @SergioBergaminiCodeploy,

Thank you for raising this issue, and making the effort to create a pull request. Your contribution is very much appreciated.
Usually we do not edit the types by hand as they are generated using the Open-API generator.
Yet the field you add seems to be missing in the current API specs. I will make sure to have the spec updated internally so this field will not be omitted in future API updates.

Kind regards,
Wouter
Adyen

@SergioBergaminiCodeploy
Copy link
Contributor Author

Hi @wboereboom !! I needed a fix to this issue so doing a PR wasn't a big effort in the end ;)
Can you give me an estimate of when this fix will be released?

@wboereboom
Copy link
Contributor

I'm discussing internally how to deal with these fields missing in the spec.
In the mean time we can review + merge this and include it in the upcoming release, which we will probably do somewhere this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants