New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] AdditionalData lacks the field paymentLinkId #787
Comments
Thank you for raising this issue, and making the effort to create a pull request. Your contribution is very much appreciated. Kind regards, |
Hi @wboereboom !! I needed a fix to this issue so doing a PR wasn't a big effort in the end ;) |
I'm discussing internally how to deal with these fields missing in the spec. |
Describe the bug
As far as I understand the APIs implementation by reading issue #494, to deserialize a webhook notification the class
NotificationRequest
must be used. So far so good. For this kind of deserialization to work, each field must be manually mapped which is of course a process prone to errors.For example, the class
AdditionalData
lacks the fieldpaymentLinkId
which is quite important and should be there based on the documentation (see https://docs.adyen.com/unified-commerce/pay-by-link/payment-links/api#notification).The text was updated successfully, but these errors were encountered: