updated platforms notification types #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR can't be reviewed/merged yet due to a bug in the API spec that causes type generation issues. currently investigating |
|
Kudos, SonarCloud Quality Gate passed!
|
wboereboom
requested review from
AlexandrosMor,
maassenbas,
peterojo and
zaiddreakh
as code owners
|
Problem solved, we can go ahead and merge this 🎉 |
maassenbas
approved these changes
Nov 4, 2021
zaiddreakh
approved these changes
Nov 5, 2021
|
Awesome! Thanks @wboereboom |
|
You're welcome! The fix is part of release 10.1.0. Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The platforms notification types have been updated to the latest API specs and have been moved from the old way of exporting types to the new
Typesexport in the library root.Fixed issue: #783