Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the translation for 'installments' doesn't add a label above the installments drop-down #2609

Open
woudsma opened this issue Mar 21, 2024 · 2 comments
Assignees
Labels
Enhancement New feature or request

Comments

@woudsma
Copy link

woudsma commented Mar 21, 2024

Describe the bug
We would like to add a localizable title above the installments drop-down. Updating the translation for installments doesn't add a label above the installments drop-down. Searching the code for i18n.get('installments') shows only 1 result so it seems like it's unused. Should there be a label or is this intended behavior and is the translation used for something else?

To Reproduce
Steps to reproduce the behavior:

  1. Enable installments
  2. Initialize AdyenCheckout with translations:
translations: {
  'en-JP': {
    installments: 'Installments',
    installmentOptionMonths: '%{times} installment(s)',
  },
}
  1. Select a card in the web drop-in
  2. Observe the installments drop-down (see screenshot)

Expected behavior
A label/title is shown.

Actual behavior
No label/title is shown.

Screenshots
Screenshot 2024-03-21 at 12 50 20

Desktop (please complete the following information):

  • OS: macOS Sonoma 14.2.1 (23C71)
  • Chrome
  • 121.0.6167.184 (Official Build) (arm64)

Additional context
It seems no label is rendered because of this prop: useLabelElement={false}. Used here.

@sponglord sponglord added Enhancement New feature or request and removed Enhancement New feature or request labels Mar 22, 2024
@m1aw
Copy link
Contributor

m1aw commented Mar 26, 2024

Hey @woudsma

This is indeed the intended behaviour. However I agree, it should be possible to set a label and even by default it should actually have a label.

I'm raising this with the design team and will update you when we got a solution.

@ArjenLa
Copy link

ArjenLa commented Mar 26, 2024

Hi @woudsma

The designer team here, it should indeed have a label!

Thanks for flagging this

@m1aw m1aw added the Enhancement New feature or request label Apr 18, 2024
@m1aw m1aw self-assigned this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants