Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional localization needs #2679

Open
huguenin opened this issue May 13, 2024 · 3 comments
Open

Additional localization needs #2679

huguenin opened this issue May 13, 2024 · 3 comments
Labels
Enhancement New feature or request v6 Included in the next major release

Comments

@huguenin
Copy link

Is your feature request related to a problem? Please describe.
We have launched a new set of languages on our website, and found that the Adyen SDK does not support these languages. As a result, we have to fall back to English, which is not a great customer experience.

Describe the solution you'd like
We would like to add translations for the following locales:

bg-bg,
ca-es,
et-ee,
lv-lv,
lt-lt,
sr-rs,
sl-si,
uk-ua,

Is this doable on Adyen's side? We could also translate this file with professional translators ourselves and contribute to this SDK, but would need a confirmation that the translations will indeed be added if we provide them.

Describe alternatives you've considered
Forking the library, but it won't change our approach and others can benefit from having the translations, too.

@huguenin huguenin added the Enhancement New feature or request label May 13, 2024
@m1aw
Copy link
Contributor

m1aw commented May 15, 2024

Hello @huguenin

Thank you for the question. As far as you translating these yourself, and creating a PR, goes - it wouldn't work for our translation workflow. What happens is that we would need to enable these languages as part of our translation pipeline, since it's likely they will have changes in the future. Therefore this is product decision.

I have sent this request to product, I will updated you if there's a decision about any of these languages.

That being said what I would recommend is to use these translations as custom translations, you can learn more in the docs: Web Integration Step 4 > Localisation.

Hope this helps.

@huguenin
Copy link
Author

Thank you @m1aw @sponglord I appreciate the input! This should be a workable way forward for us. Could you additionally provide guidance on how the localizations for adyen-web are best transferred to adyen-ios and adyen-android, and if these offer similar capabilities? From our research, it seems like the translations are structured differently, and it would be good to know if there are any guidelines on how to re-use localized strings across platforms.

@sponglord
Copy link
Contributor

@huguenin
FYI: In v6 we will be adding the languages: Catalan, Icelandic, Bulgarian, Estonian, Latvian and Lithuanian
Some of these are languages you've requested - these have coincided with other requests we've had for these localisations.

Regarding the remaining translations (Serbian, Slovenian and Ukrainian) - we have a policy of waiting for multiple requests for a language before we add it.
In the meantime @m1aw detailed how you can add these yourself.

Once the new localisations have been created we will inform the iOS & Android SDK teams and they will be able to add these to their products in a new releases.

@sponglord sponglord added v6 Included in the next major release and removed Progress: on hold labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request v6 Included in the next major release
Projects
None yet
Development

No branches or pull requests

3 participants