Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnesseray dependencies! #1182

Open
henrydf opened this issue Apr 12, 2024 · 4 comments
Open

Remove unnesseray dependencies! #1182

henrydf opened this issue Apr 12, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@henrydf
Copy link

henrydf commented Apr 12, 2024

Is your feature request related to a problem? Please describe.
Why this SDK requires some annoying things such as gulp* and ts-interface-checker in production dependencies?

Describe the solution you'd like
Keep production dependencies clear.

Describe alternatives you've considered
Or provide some pre-bundled version in dist or somewhere.

Additional context
Current dependencies make bundle result mess.

@guoxianzhe
Copy link
Collaborator

@henrydf Thanks for your advice!
Currently, gulp is necessary, this will download our c++ native modules when you install Electron-SDK.
ts-interface-checker is necessary when we check some variables in runtime.

If you have any suggestions please leave a message.

@henrydf
Copy link
Author

henrydf commented Apr 12, 2024

How about provide a prebuild version of js/ts files. Then I just need to bundle the prebuild result instead of 500+ dependencies.

@guoxianzhe
Copy link
Collaborator

@henrydf The main reason for this problem is gulp IMO. Maybe We can remove gulp in the future. I will talk with my team and make it happen in the feature. This gonna be a huge work to do and please wait my further progress.

@henrydf
Copy link
Author

henrydf commented Apr 16, 2024

Glad to see it.

@guoxianzhe guoxianzhe added the enhancement New feature or request label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants