Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create example dapp in @agoric/react-components with e2e testing #86

Open
samsiegart opened this issue Feb 26, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@samsiegart
Copy link
Contributor

What is the Problem Being Solved?

For testability and local development, it would be beneficial to have an example app in packages/react-components that shows how to use the components and provides a basis for e2e testing.

Description of the Design

Create an example react app in packages/react-components/src/example that can be bundled separately from src/lib.

TODO integration testing details, pending contract work on dapp-offer-up.

@samsiegart samsiegart added the enhancement New feature or request label Feb 26, 2024
@LuqiPan
Copy link

LuqiPan commented Feb 26, 2024

Just trying to understand the priority here, would this issue be part of this sprint?

@samsiegart
Copy link
Contributor Author

@LuqiPan I don't think it's in scope for this sprint because the e2e testing will use some incoming work from the contractors. I'm sticking to the priorities of Agoric/agoric-sdk#8893 and Agoric/agoric-sdk#8933 (might decide to start on the example app along the way at some point, but not a priority currently)

@LuqiPan
Copy link

LuqiPan commented Feb 29, 2024

Got it. I'll hit you up if I need some code examples then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants