Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service workers #37

Closed
KyGost opened this issue Oct 4, 2020 · 9 comments
Closed

Service workers #37

KyGost opened this issue Oct 4, 2020 · 9 comments
Labels
dependant This issue or pull request is dependant on something else electron Related to electron, might require fixes from upstream question Further information is requested

Comments

@KyGost
Copy link
Member

KyGost commented Oct 4, 2020

I saw service workers/PWAs on the development roadmap:

Spec lists this as being HTTPS only.

Shall Agregore break this?

@RangerMauve
Copy link
Member

I'd love to break it and make service workers work on hyper:// and other such protocols, but I think it'd be up to Electron to implement the functionality and I'm not sure when I'd have time to get around to it.

Have you tested to confirm that it breaks on hyper:// URLs?

@RangerMauve RangerMauve added the question Further information is requested label Oct 4, 2020
@KyGost
Copy link
Member Author

KyGost commented Oct 5, 2020

Yup. At least it does with Beaker.

@RangerMauve
Copy link
Member

Yeah, I think it'd be good to open an issue on Electron and follow up there.

@ikreymer
Copy link

ikreymer commented Oct 5, 2020

Unfortunately, service worker support for custom protocols has been broken for a while in Electron (maybe never worked?):
electron/electron#9663
electron/electron#20248

@KyGost KyGost added the dependant This issue or pull request is dependant on something else label Nov 8, 2020
@KyGost
Copy link
Member Author

KyGost commented Nov 13, 2020

I've proposed that we put up a bounty for the Electron issue.
Awaiting response from the Beaker team.

I don't have too much to give but I'll put up $50AUD (personal money) for it.
($35USD / 0.08ETH)
I may up it later if I have more to give and it's still unsolved.

@KyGost KyGost added the electron Related to electron, might require fixes from upstream label Nov 13, 2020
@RangerMauve
Copy link
Member

I think I'd be down to throw another 100 USD in there. 😁

@RangerMauve
Copy link
Member

The service worker stuff doesn't seem too hard to do.

There's a service_worker_schemes variable that we could make use of: https://github.com/electron/electron/blob/1c99a9b425dd026b4be939486b48bd48022fee82/shell/app/electron_content_client.cc#L209

@RangerMauve
Copy link
Member

Looks like this might be getting fixed in Electron 19? electron/electron#34290

@ikreymer
Copy link

This finally works in latest electron and in Agregore builds on 19.x!

@av8ta av8ta closed this as completed Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependant This issue or pull request is dependant on something else electron Related to electron, might require fixes from upstream question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants